Add help text for all subcommands #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebraham
requested review from
bjoernQ,
MabezDev,
SergioGasquez and
JurajSadel
bjoernQ
reviewed
Jul 6, 2023
bjoernQ
approved these changes
Jul 6, 2023
SergioGasquez
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
LGTM! Just one small detail that we could add, as some people are confused with this, is that cargo-espflash is able to detect if the app uses esp-idf-sys and if using it, will reuse the partition table and bootloader esp-idf while espflash uses a "hardcoded" bootloader and partition table. But, feel free to disregard it as it's already on the README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've kept these fairly minimal for the time being, with the expectation that we will expand on the help text as needed. With that said, would still like to get some feedback on what I have included.