Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update 'cargo' dependency to 0.72 #445

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

mykmelez
Copy link
Contributor

In #444, I reported that cargo install of cargo-espflash started failing for me this morning due to a build failure in the "cargo" dependency:

> cd cargo-espflash
> cargo install --path .
…
error[E0063]: missing field `rust_version` in initializer of `NewCrate`
   --> /Users/myk/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cargo-0.71.0/src/cargo/ops/registry.rs:383:14
    |
383 |             &NewCrate {
    |              ^^^^^^^^ missing `rust_version`

For more information about this error, try `rustc --explain E0063`.
error: could not compile `cargo` (lib) due to previous error
error: failed to compile `cargo-espflash v2.0.1-dev (/Users/myk/Projects/espflash/cargo-espflash)`, intermediate artifacts can be found at `/Users/myk/Projects/espflash/target`

This branch fixes that problem by updating the dependency to 0.72, which was just published this morning (https://crates.io/crates/cargo/versions). Unfortunately, I can't find any info about the changes that were made. There isn't even a tag in the repo for the crate (https://github.com/rust-lang/cargo/tags). So I'm not sure what the issue is nor how updating the dependency fixes it.

However, I also see that Rust 1.71 was released today (https://blog.rust-lang.org/2023/07/13/Rust-1.71.0.html), so maybe it's something to do with that.

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very strange issue, thanks for the fix!

@jessebraham jessebraham merged commit 7ce1ca2 into esp-rs:main Jul 13, 2023
19 checks passed
@mykmelez
Copy link
Contributor Author

@jessebraham, would it make sense to release a new version of cargo-espflash with this fix?

@jessebraham
Copy link
Member

Yeah I think so, I'll get a patch release out today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants