Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interactive flag #455

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Add interactive flag #455

merged 3 commits into from
Nov 7, 2023

Conversation

jneem
Copy link
Contributor

@jneem jneem commented Aug 5, 2023

Adds an --interactive (or -i) flag that prevents auto-connection to a recognized device, even if it is the only recognized one.

@SergioGasquez SergioGasquez added this to the v3 milestone Sep 21, 2023
@SergioGasquez
Copy link
Member

Hi! We've just started working towards version 3.0, do you mind rebasing your changes so we can merge them?

@jneem
Copy link
Contributor Author

jneem commented Nov 4, 2023

Rebased. I noticed while testing it that the -f flag is used for both flash_freq and log_format, triggering a debug_assertion in clap.

@SergioGasquez SergioGasquez mentioned this pull request Nov 6, 2023
Closed
@SergioGasquez
Copy link
Member

SergioGasquez commented Nov 6, 2023 •
edited
Loading

Rebased. I noticed while testing it that the -f flag is used for both flash_freq and log_format, triggering a debug_assertion in clap.

Thanks for the heads-up, just created an issue for it! Update: #499 should fix this

SergioGasquez
SergioGasquez approved these changes Nov 6, 2023
View reviewed changes
espflash/src/cli/mod.rs Outdated Show resolved Hide resolved
@SergioGasquez
Copy link
Member

One last thing! Do you mind updating the CHANGELOG?

@jneem
Copy link
Contributor Author

jneem commented Nov 6, 2023

Sure thing

@SergioGasquez SergioGasquez merged commit 3051241 into esp-rs:main Nov 7, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3
Development

Successfully merging this pull request may close these issues.
2 participants
@jneem @SergioGasquez