Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay processing of incomplete UTF-8 sequences #468

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Delay processing of incomplete UTF-8 sequences #468

merged 1 commit into from
Sep 12, 2023

Conversation

bugadani
Copy link
Contributor

Closes #457

@bugadani bugadani force-pushed the string branch 2 times, most recently from f543e12 to 454f9e1 Compare August 27, 2023 06:56
@bugadani bugadani marked this pull request as ready for review August 27, 2023 06:56
MabezDev
MabezDev approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! All the CI errors appear to be RPI-related so, I will just go ahead and merge this.

MabezDev
MabezDev requested changes Sep 4, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there a couple of clippy lints to resolve, could you take care of that first?

@bugadani
Copy link
Contributor Author

bugadani commented Sep 4, 2023 •
edited
Loading

I'd prefer #465 merged first. I'm not sure why clap no longer fails to compile, but a clean bill of health will be preferable over forcing in some reds.

jessebraham
jessebraham approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this!

@jessebraham jessebraham merged commit 5b3dee0 into esp-rs:main Sep 12, 2023
19 checks passed
@bugadani bugadani deleted the string branch September 12, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev requested changes

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird println! issue
3 participants
@bugadani @jessebraham @MabezDev