Flush buffer after writing command #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioGasquez
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Good catch! From the BufWriter docs:
It is critical to call flush before BufWriter is dropped.
Lets see if it fix any issues!
|
Do you mind adding an entry to the changelog? (I always remember this after approving the changes) |
It fixes mine :) |
That's already a big thing! Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping
BufWriterflushes the internal buffers, but doesn't flush the inner stream. Callingflushdirectly does both and also propagates any IO errors back to the caller.May fix (or may not fix) issues like #450