Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't silently fail if defmt data isn't available/correct #524

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Don't silently fail if defmt data isn't available/correct #524

merged 4 commits into from
Nov 29, 2023

Conversation

bugadani
Copy link
Contributor

Closes #523

SergioGasquez
SergioGasquez reviewed Nov 29, 2023
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements! Just left a few nitpicks in comments.

Also, mind updating the CHANGELOG?

espflash/src/cli/monitor/parser/esp_defmt.rs Outdated Show resolved Hide resolved
espflash/src/cli/monitor/parser/esp_defmt.rs Outdated Show resolved Hide resolved
SergioGasquez
SergioGasquez approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@SergioGasquez SergioGasquez merged commit 71d7a63 into esp-rs:main Nov 29, 2023
19 checks passed
@bugadani bugadani deleted the defmt branch November 29, 2023 09:14
@Vollbrecht
Copy link

Ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error out in some form when no table could be found parsing an elf for defmt
3 participants
@bugadani @Vollbrecht @SergioGasquez