Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different crystal frequencies bootloader #553

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

SergioGasquez
Copy link
Member

  • Add bootloarder for ESP32 26MHz and ESP32-C2 26MHz
  • When using flash use the target xtal_freq to choose the bootloader
  • When using save-image add a -x/--xtal-freq arg to choose the bootloader.
  • Add a XtalFrequency enum to avoid hardcoded values.

@SergioGasquez SergioGasquez linked an issue Jan 18, 2024 that may be closed by this pull request
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Annoying that we have to lug around some more bootloaders, but given that we've only seen 26mhz xtals on the esp32 and esp32c2, its not too bad.

Thanks for working on this!

@SergioGasquez
Copy link
Member Author

As usual, I forgot to update the changelog, so I just did it and also formatted other changelog entries

@MabezDev
Copy link
Member

As usual, I forgot to update the changelog, so I just did it and also formatted other changelog entries

Maybe you can steal our CI config on esp-hal and esp-wifi to make sure we add entries. That can wait for another PR though, if you wish!

@SergioGasquez
Copy link
Member Author

As usual, I forgot to update the changelog, so I just did it and also formatted other changelog entries

Maybe you can steal our CI config on esp-hal and esp-wifi to make sure we add entries. That can wait for another PR though, if you wish!

This was discussed when we added the changelog, #416 (comment), but we decided not to add it as it also has drawbacks

@MabezDev
Copy link
Member

I think that was before we fixed the fork issue around skip-changelog, @jessebraham will be able to confirm. Either way just a suggestion, feel free to ignore! Let's get this merged :).

@MabezDev MabezDev merged commit 027e24b into esp-rs:main Jan 24, 2024
19 checks passed
@SergioGasquez SergioGasquez deleted the feat/c2-26mhz branch January 24, 2024 15:54
@jessebraham
Copy link
Member

Yes that was before we figured out how to properly use the workflow, no problem to add it now I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP32-C2 26MHz logs don't work properly
3 participants