Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FlashDataBuilder #566

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Add FlashDataBuilder #566

merged 1 commit into from
Jan 31, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Jan 30, 2024 •
edited
Loading

This PR implements my suggestions from #512 (comment) except for the error handling which is a more fundamental question it looks like.

@bugadani bugadani marked this pull request as ready for review January 30, 2024 17:16
SergioGasquez
SergioGasquez approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@SergioGasquez SergioGasquez merged commit 31817fa into esp-rs:main Jan 31, 2024
20 checks passed
@bugadani bugadani deleted the api branch January 31, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bugadani @SergioGasquez