Tolerate some non-utf8 data when detecting boot mode over serial #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My ESP32-WROOM is sending some non-utf8 data just after reset, causing boot mode detection to fail. This commit uses `String::from_utf8_lossy` to ignore these bytes. Tested on macOS, boards: ESP32-WROOM-32, ESP32-WROOM-32D, ESP32-C3-MINI-1, ESP32-C3-12F.
There was a problem hiding this comment.
Hello! Mind testing what's the behavior with esptool?
My reasoning behind not using _lossy was that it can lead to "unhelpful" error messages, using branch in the #570 scenario, results in:
[2024-02-05T10:08:48Z INFO ] Serial port: '/dev/ttyUSB0'
[2024-02-05T10:08:48Z INFO ] Connecting...
Connect attempt
[2024-02-05T10:08:48Z INFO ] Using flash stub
Error: espflash::timeout
× Error while connecting to device
╰─▶ Timeout while running command
This scenario is not common I'd say, but yet the error message is pretty confusing to the user.
Merged
SergioGasquez
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My ESP32-WROOM is sending some non-utf8 data just after reset, causing boot mode detection to fail.
This commit uses
String::from_utf8_lossyto ignore these bytes.Tested on macOS, boards: ESP32-WROOM-32, ESP32-WROOM-32D, ESP32-C3-MINI-1, ESP32-C3-12F.