Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for Raspberry Pi's internal UART peripherals #585

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Remove support for Raspberry Pi's internal UART peripherals #585

merged 6 commits into from
Feb 16, 2024

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Feb 16, 2024 •
edited
Loading

  • Remove raspberry feature
  • Remove interface module
  • Use Port types instead of Interface

@SergioGasquez SergioGasquez changed the title Remove raspberry feature Remove support for Raspberry Pi's internal UART peripherals Feb 16, 2024
@SergioGasquez SergioGasquez linked an issue Feb 16, 2024 that may be closed by this pull request
Does anybody actually use the raspberry feature? Should it be removed? #579
Closed
MabezDev
MabezDev approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can always add it back if it really is used a lot.

@SergioGasquez SergioGasquez merged commit 0a5d5e6 into esp-rs:main Feb 16, 2024
20 checks passed
@SergioGasquez SergioGasquez deleted the feat/remove-raspberry branch February 16, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does anybody actually use the raspberry feature? Should it be removed?
2 participants
@SergioGasquez @MabezDev