Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return crate::Error instead of a miette Report #591

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Return crate::Error instead of a miette Report #591

merged 1 commit into from
Feb 21, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Feb 20, 2024 •
edited
Loading

cc #587

@bugadani bugadani marked this pull request as ready for review February 20, 2024 19:59
@SergioGasquez SergioGasquez linked an issue Feb 21, 2024 that may be closed by this pull request
Library should not rely on miette #587
Closed
SergioGasquez
SergioGasquez approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your help on testing and fixing this!

@SergioGasquez SergioGasquez merged commit 7f41ad8 into esp-rs:main Feb 21, 2024
20 checks passed
@bugadani bugadani deleted the error branch February 21, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Library should not rely on miette
2 participants
@bugadani @SergioGasquez