Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Cargo workspace config file #595

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Allow Cargo workspace config file #595

merged 2 commits into from
Feb 21, 2024

Conversation

SergioGasquez
Copy link
Member

  • Local espflash.toml config file can also be stored in parent folder to simplify Cargo workspaces

@SergioGasquez SergioGasquez linked an issue Feb 21, 2024 that may be closed by this pull request
espflash should look at parent/workspace directories for espflash.toml #593
Closed
@SergioGasquez SergioGasquez mentioned this pull request Feb 21, 2024
Closed
MabezDev
MabezDev approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MabezDev MabezDev merged commit 14befdc into esp-rs:main Feb 21, 2024
20 checks passed
@SergioGasquez SergioGasquez deleted the feat/workspace-dir branch February 21, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

espflash should look at parent/workspace directories for espflash.toml
2 participants
@SergioGasquez @MabezDev