Turn off some dependencies for library users #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
features
branch
8 times, most recently
from
79ae339
to
22dde0f
Compare
bugadani
force-pushed
the
features
branch
3 times, most recently
from
4e1bb45
to
22d38e1
Compare
|
I'm going to assume that the apple error ( |
Feel free to ignore it, see #597, it should now be fixed though. Thanks for the PR, will review it on Monday! |
|
cc 1.0.88 should fix this for make < 4.3 |
SergioGasquez
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I hide some code behind the
serialportfeature. The code was otherwise available, but not really useful without the feature. Additionally, I'm making certain dependencies optional that were only used with either cli or serialport only. Lastly, I'm moving some code (chieflyProgressCallbacks[defined together withFlashTarget] andchecksum[only used in one place]) to new locations where I believe they better belong.