-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 3.1.0 #639
Version 3.1.0 #639
Conversation
388e710
to
74d89a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the MSRV bump affect the library, or just the binaries? If it affects the library then its a breaking change :(
Ah I see you've done it in this PR - was there a reason to do so? If not IMO we should revert. |
I think it should affect |
Maybe we should make the MSRV check only check for the library then, and make no guarantee about the binaries (they can install from binstall or gh releases if they want stability)? |
48a36fe
to
c0a771a
Compare
c0a771a
to
5187e02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
espflash
andcargo-espflash
version