Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commands reset and hold-in-reset #644

Merged
merged 5 commits into from
Jun 6, 2024

Conversation

jnross
Copy link
Contributor

@jnross jnross commented May 28, 2024

We found these commands to be useful for our team.

@jnross jnross force-pushed the joe/upstream-reset-commands branch from eb27335 to eed83f8 Compare May 28, 2024 15:54
@jnross
Copy link
Contributor Author

jnross commented May 28, 2024

Sorry for the noise here. I cherry-picked this from a branch that was based on 2.1.0. I'll clean it up shortly.

@jnross
Copy link
Contributor Author

jnross commented May 28, 2024

Ok, the mess is cleaned up now. Please let me know what you think. I considered whether to add these commands to cargo-espflash as well but I can't think of a use case for it. We generally use cargo-espflash for specialized purposes (like build & flash), and espflash is our more general-purpose tool to react to any given scenario.

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! The commands can be handy for some users! I would also add the commands for cargo-espflash as some user might not use both tools as you do.

@jnross
Copy link
Contributor Author

jnross commented May 31, 2024

Thanks for the contribution! The commands can be handy for some users! I would also add the commands for cargo-espflash as some user might not use both tools as you do.

Sounds good, I will do so.

@jnross
Copy link
Contributor Author

jnross commented May 31, 2024

@SergioGasquez: Thanks for your review! I've updated this set of changes to also add these commands to cargo-espflash.

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@SergioGasquez
Copy link
Member

SergioGasquez commented Jun 3, 2024

Ups! I just noticed that we forgot to update the usage section of cargo-espflash and espflash, mind updating it? Sorry

Edit: Let me know if you prefer me to do it, and we can merge it as it is and I'll update the usage section in a different PR

@jnross
Copy link
Contributor Author

jnross commented Jun 6, 2024

@SergioGasquez: I just pushed this fix. Thanks for catching that!

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the features!

@SergioGasquez SergioGasquez merged commit 5c898ac into esp-rs:main Jun 6, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants