This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
lib: Print better error for invalid baudrate #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way the serial crate in use is written it will accept any arbitrary baudrate and try to configure the interface with it. This can fail if the underlying hardware doesn't support the given baudrate. Previously the code would simply output an `Error: Invalid argument`, which leaves the user guessing which part of their input was invalid. This patch adds an additional check on the error type returned by configuring the serial device. If it returns an `InputError`, we assume that in fact the baud rate was invalid (Because that is the only setting we change) and print a better error message to the user.
kelnos
approved these changes
May 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the serial crate in use is written it will accept any arbitrary
baudrate and try to configure the interface with it. This can fail if
the underlying hardware doesn't support the given baudrate.
Previously the code would simply output an
Error: Invalid argument,which leaves the user guessing which part of their input was invalid.
This patch adds an additional check on the error type returned by
configuring the serial device. If it returns an
InputError, we assumethat in fact the baud rate was invalid (Because that is the only setting
we change) and print a better error message to the user.