Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

Remove chip features from xtensa-lx package, add a super simple CI workflow #34

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Remove chip features from xtensa-lx package, add a super simple CI workflow #34

merged 3 commits into from
Feb 19, 2024

Conversation

jessebraham
Copy link
Member

  • Removes the chip features from xtensa-lx, as they are no longer needed; the spin feature replaces them, which is used with the ESP32 and ESP32-S3.
  • Add rustfmt config file, format packages (sorry for the noise)
  • Add a super simple CI workflow to check formatting and build packages__*__
    • I'm getting some weird error trying to build xtensa-lx-rt using GHA for whatever reason. I've disabled these checks for now, and will get them working in my next PR (as I plan to remove core-isa-parser, the source of our issues (I think) ).

@jessebraham jessebraham requested a review from MabezDev February 15, 2024 17:25
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@MabezDev MabezDev merged commit 1a028a9 into esp-rs:main Feb 19, 2024
2 checks passed
@jessebraham jessebraham deleted the fixes/updates branch February 20, 2024 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants