New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change EEPROM.end() return type from void to bool #7423

Closed

mrv96 opened this issue Jul 2, 2020 · 1 comment

mrv96 commented Jul 2, 2020

According to docs, EEPROM.end() in https://github.com/esp8266/Arduino/blob/master/libraries/EEPROM/EEPROM.cpp is a commit() followed by a free of used RAM.

Since commit() return a bool, also end() should return a bool to check if the commit failed or not.

Collaborator

d-a-v commented Aug 12, 2020

Will you propose a pull-request for that suggestion ?

Erriez added a commit to Erriez/Arduino that referenced this issue


          Issue esp8266#7423: Change return EEPROM.end() to bool

664ae3b

Erriez mentioned this issue

BREAKING: Change return EEPROM.end() to bool #7630

Merged

earlephilhower closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment