Upgrade to GCC 10.1 toolchain

bootloaders/eboot/Makefile

@@ -23,7 +23,7 @@ INC += -I../../tools/sdk/include -I../../tools/sdk/uzlib/src
 
 CFLAGS += -std=gnu99
 
-CFLAGS += -Os -g -Wall -Wpointer-arith -Wno-implicit-function-declaration -Wl,-EL -fno-inline-functions -nostdlib -mlongcalls -mno-text-section-literals -ffunction-sections -fdata-sections
+CFLAGS += -Os -fcommon -g -Wall -Wpointer-arith -Wno-implicit-function-declaration -Wl,-EL -fno-inline-functions -nostdlib -mlongcalls -mno-text-section-literals -ffunction-sections -fdata-sections
 
 CFLAGS += $(INC)
 

cores/esp8266/Arduino.h

@@ -127,14 +127,8 @@ void timer0_isr_init(void);
 void timer0_attachInterrupt(timercallback userFunc);
 void timer0_detachInterrupt(void);
 
-// undefine stdlib's abs if encountered
-#ifdef abs
-#undef abs
-#endif
-
-#define abs(x) ((x)>0?(x):-(x))
+// Use stdlib abs() and round() to avoid issues with the C++ libraries
 #define constrain(amt,low,high) ((amt)<(low)?(low):((amt)>(high)?(high):(amt)))
-#define round(x)     ((x)>=0?(long)((x)+0.5):(long)((x)-0.5))
 #define radians(deg) ((deg)*DEG_TO_RAD)
 #define degrees(rad) ((rad)*RAD_TO_DEG)
 #define sq(x) ((x)*(x))
@@ -249,6 +243,7 @@ const int TIM_DIV265 __attribute__((deprecated, weak)) = TIM_DIV256;
 
 using std::min;
 using std::max;
+using std::round;
 using std::isinf;
 using std::isnan;
 

cores/esp8266/core_esp8266_features.cpp

@@ -37,8 +37,9 @@ void precache(void *f, uint32_t bytes) {
   // page (ie 1 word in 8) for this to work.
   #define CACHE_PAGE_SIZE 32
 
-  register uint32_t a0 asm("a0");
-  register uint32_t lines = (bytes/CACHE_PAGE_SIZE)+2;
+  uint32_t a0;
+  __asm__("mov.n %0, a0" : "=r"(a0));
+  uint32_t lines = (bytes/CACHE_PAGE_SIZE)+2;
   volatile uint32_t *p = (uint32_t*)((f ? (uint32_t)f : a0) & ~0x03);
   uint32_t x;
   for (uint32_t i=0; i<lines; i++, p+=CACHE_PAGE_SIZE/sizeof(uint32_t)) x=*p;

cores/esp8266/core_esp8266_timer.cpp

@@ -31,8 +31,9 @@ extern "C" {
 
 static volatile timercallback timer1_user_cb = NULL;
 
-void ICACHE_RAM_ATTR timer1_isr_handler(void *para){
+void ICACHE_RAM_ATTR timer1_isr_handler(void *para, void *frame) {
     (void) para;
+    (void) frame;
     if ((T1C & ((1 << TCAR) | (1 << TCIT))) == 0) TEIE &= ~TEIE1;//edge int disable
     T1I = 0;
     if (timer1_user_cb) {
@@ -79,8 +80,9 @@ void ICACHE_RAM_ATTR timer1_disable(){
 
 static volatile timercallback timer0_user_cb = NULL;
 
-void ICACHE_RAM_ATTR timer0_isr_handler(void* para){
+void ICACHE_RAM_ATTR timer0_isr_handler(void *para, void *frame) {
     (void) para;
+    (void) frame;
     if (timer0_user_cb) {
         // to make ISR compatible to Arduino AVR model where interrupts are disabled
         // we disable them before we call the client ISR

cores/esp8266/core_esp8266_wiring_digital.cpp

@@ -130,8 +130,10 @@ typedef struct {
 static interrupt_handler_t interrupt_handlers[16] = { {0, 0, 0, 0}, };
 static uint32_t interrupt_reg = 0;
 
-void ICACHE_RAM_ATTR interrupt_handler(void*)
+void ICACHE_RAM_ATTR interrupt_handler(void *arg, void *frame)
 {
+  (void) arg;
+  (void) frame;
   uint32_t status = GPIE;
   GPIEC = status;//clear them interrupts
   uint32_t levels = GPI;

cores/esp8266/gdb_hooks.cpp

@@ -31,6 +31,11 @@ static bool ICACHE_RAM_ATTR __gdb_no_op()
     return false;
 }
 
+// To save space, don't create a dummy no-op for each GCC, just point to the no-op
+// Need to turn off GCC's checking of parameter types or we'll get many warnings
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wattribute-alias"
+#pragma GCC diagnostic ignored "-Wmissing-attributes"
 void gdb_init(void) __attribute__ ((weak, alias("__gdb_no_op")));
 void gdb_do_break(void) __attribute__ ((weak, alias("__gdb_no_op")));
 bool gdb_present(void) __attribute__ ((weak, alias("__gdb_no_op")));
@@ -40,5 +45,6 @@ bool gdbstub_has_uart_isr_control(void) __attribute__ ((weak, alias("__gdb_no_op
 void gdbstub_set_uart_isr_callback(void (*func)(void*, uint8_t), void* arg) __attribute__ ((weak, alias("__gdb_no_op")));
 void gdbstub_write_char(char c) __attribute__ ((weak, alias("__gdb_no_op")));
 void gdbstub_write(const char* buf, size_t size) __attribute__ ((weak, alias("__gdb_no_op")));
+#pragma GCC diagnostic pop
 
 };

cores/esp8266/uart.cpp

@@ -371,8 +371,9 @@ uart_get_rx_buffer_size(uart_t* uart)
 
 // The default ISR handler called when GDB is not enabled
 void ICACHE_RAM_ATTR
-uart_isr(void * arg)
+uart_isr(void * arg, void * frame)
 {
+    (void) frame;
     uart_t* uart = (uart_t*)arg;
     uint32_t usis = USIS(uart->uart_nr);
 

libraries/SPISlave/src/hspi_slave.c

@@ -28,8 +28,9 @@ static void (*_hspi_slave_rx_status_cb)(void * arg, uint32_t data) = NULL;
 static void (*_hspi_slave_tx_status_cb)(void * arg) = NULL;
 static uint8_t _hspi_slave_buffer[33];
 
-void ICACHE_RAM_ATTR _hspi_slave_isr_handler(void *arg)
+void ICACHE_RAM_ATTR _hspi_slave_isr_handler(void *arg, void *frame)
 {
+    (void) frame;
     uint32_t status;
     uint32_t istatus;
 

libraries/Ticker/src/Ticker.h

@@ -74,16 +74,22 @@ class Ticker
     template<typename TArg>
     void attach(float seconds, void (*callback)(TArg), TArg arg)
     {
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wcast-function-type"
         static_assert(sizeof(TArg) <= sizeof(void*), "attach() callback argument size must be <= sizeof(void*)");
         _attach_ms(1000UL * seconds, true, reinterpret_cast<callback_with_arg_t>(callback), reinterpret_cast<void*>(arg));
+#pragma GCC diagnostic pop
     }
 
     // callback will be called in SYS ctx when ticker fires
     template<typename TArg>
     void attach_ms(uint32_t milliseconds, void (*callback)(TArg), TArg arg)
     {
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wcast-function-type"
         static_assert(sizeof(TArg) <= sizeof(void*), "attach() callback argument size must be <= sizeof(void*)");
         _attach_ms(milliseconds, true, reinterpret_cast<callback_with_arg_t>(callback), reinterpret_cast<void*>(arg));
+#pragma GCC diagnostic pop
     }
 
     // callback will be called at following loop() after ticker fires