WString: mark move ctor as noexcept #7610
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref.
With a basic example based on the
master
Since the vector is not using
.reserve(...)
, we need to realloc + move existing vector contents every push when vector needs more capacity. Without the patch, we will never see themoved!
string from the above.Core does use
std::vector<String>
in a couple of places as well, it is not just possible user code:(But, I am not sure what is the implication for the overall Arduino API stuff. Does it need the patch, too, if this is valid?)