Fix header FSM in webserver, fix Windows uploads #7805
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a file upload ends in \r\n (i.e. a Windows formatted text file) the
sequence of bytes on the wire is
\r\n\r\n----...boundary-marker...
.When the FSM in Webserver was evaluating the stream, that 2nd
\r
wouldbe written as valid data and the FSM parser would be reset and see
\n
as the 1st character, which wouldn't match. This would a) add an extra
\r
to uploaded files, and b) cause uploads to hang.Fix by checking on a header FSM mismatch if the next character input
could possibly match our marker, and if so handle it properly.
Fixes #7803