Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDNS.end() also needs to release services #7859

Merged
merged 2 commits into from
Feb 4, 2021
Merged

MDNS.end() also needs to release services #7859

merged 2 commits into from
Feb 4, 2021

Conversation

hreintke
Copy link
Contributor

@hreintke hreintke commented Feb 3, 2021

Fixes #7856

@hreintke hreintke mentioned this pull request Feb 3, 2021
Closed
@d-a-v d-a-v added the alpha included in alpha release label Feb 3, 2021
d-a-v
d-a-v approved these changes Feb 4, 2021
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (also per verification by reporter)

@d-a-v d-a-v merged commit 27da347 into esp8266:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devyte devyte devyte approved these changes

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
alpha included in alpha release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash occurs when I try to execute MDNS.removeService
3 participants
@hreintke @d-a-v @devyte