Move varuint functions into plain_text frame_helper #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are only used in the plaintext frame helper.
These are only used in the plaintext frame helper.
bdraco
commented
Oct 17, 2023
bdraco
commented
Oct 17, 2023
Codecov Report
@@ Coverage Diff @@
## main #587 +/- ##
==========================================
+ Coverage 70.15% 70.18% +0.03%
==========================================
Files 14 14
Lines 2439 2442 +3
==========================================
+ Hits 1711 1714 +3
Misses 728 728
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bdraco
changed the title
bdraco
commented
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are only used in the plain_text frame helper. When I split up the frame helpers I forgot to move them.