Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Fix MCP23017 to work on OUTPUT mode. #571

Merged
merged 2 commits into from
Mar 31, 2019

Conversation

puerari
Copy link
Contributor

@puerari puerari commented Mar 25, 2019

Description:

Related issue (if applicable): fixes

Pull request in esphome with python changes (if applicable): esphome/esphome#
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Checklist:

  • The code change is tested and works locally.
  • The code change follows the standards

If user exposed functionality or configuration variables are added/changed:

@puerari
Copy link
Contributor Author

puerari commented Mar 27, 2019

Can someone explain what is Travis CI?
Need I do something more to merge the pull request?
It is my first pull request.
Thanks.

@OttoWinter
Copy link
Member

It's lint checks that run over your code to check for consistency. Press on it to see the failing line. You've got a trailing space in a line that needs to be removed.

@OttoWinter OttoWinter merged commit ac3fcce into esphome:dev Mar 31, 2019
@OttoWinter OttoWinter added this to the 1.12.2 milestone Mar 31, 2019
OttoWinter pushed a commit that referenced this pull request Mar 31, 2019
* Fix MCP23017 to work on OUTPUT mode.

* extra space removed
@esphome esphome locked and limited conversation to collaborators Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants