Update OtaUrl for migration from tasmota #4289
Conversation
WalkthroughThe document has been revised to include critical updates regarding the migration from Tasmota to ESPHome. Key changes include a warning about OTA migration risks for ESP32 devices running Tasmota v12 and above, expanded instructions for obtaining and uploading binaries, and clarifications regarding storage limitations for ESP8266 devices. The automated migration command in the Tasmota console has also been updated to reflect changes in the URL structure. Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
guides/migrate_sonoff_tasmota.rst (1)
107-107: Approved: URL parameter updated correctly.The change from
firmware-factory.bintofirmware.binin the OtaUrl command aligns with the PR objective of correcting the OTA download URL. This update ensures that users will download the correct firmware file when migrating from Tasmota to ESPHome.Consider adding a brief explanation of why this change was made. For example:
OtaUrl http://<MY-ESPHOME:6052>/download.bin?configuration=<MY_DEVICE>.yaml&type=firmware.bin&compressed=1 + # Note: We use 'firmware.bin' instead of 'firmware-factory.bin' to ensure compatibility with the latest ESPHome builds. Upgrade 1This additional context can help users understand the reasoning behind the change and potentially prevent confusion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- guides/migrate_sonoff_tasmota.rst (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
guides/migrate_sonoff_tasmota.rst (1)
Pattern
**: - Do not generate or add any sequence diagrams
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
guides/migrate_sonoff_tasmota.rst (1)
107-107: Approved: OtaUrl command updated correctly.The OtaUrl command has been successfully updated to reflect the new URL structure. This change aligns with the PR objectives and improves the migration process.
Consider adding a brief comment explaining the purpose of the
compressed=1parameter, such as:# Add '&compressed=1' for Tasmota 8.2+ to use gzipped binaries (smaller size) OtaUrl http://<MY-ESPHOME:6052>/download.bin?configuration=<MY_DEVICE>.yaml&file=firmware.bin&compressed=1This addition would help users understand why the parameter is included and its relevance to different Tasmota versions.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- guides/migrate_sonoff_tasmota.rst (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
guides/migrate_sonoff_tasmota.rst (1)
Pattern
**: - Do not generate or add any sequence diagrams
Description:
Fixes ota download url in tasmota migration guide.
Checklist:
I am merging into
nextbecause this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/index.rstwhen creating new documents for new components or cookbook.