Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ESPTime into core esphome namespace #4926

Merged
merged 7 commits into from
Jun 8, 2023
Merged

Move ESPTime into core esphome namespace #4926

merged 7 commits into from
Jun 8, 2023

Conversation

jesserockz
Copy link
Member

@jesserockz jesserockz commented Jun 8, 2023

What does this implement/fix?

This moves the ESPTime class into a core "helper" file so it can be used without time components being required.

This is a breaking change for any external_components that use ESPTime as it has moved out of the time:: namespace, and should now use #include "esphome/core/time.h".

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): Part of esphome/feature-requests#2267

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@jesserockz jesserockz marked this pull request as draft June 8, 2023 03:58
@jesserockz jesserockz marked this pull request as ready for review June 8, 2023 04:40
@jesserockz jesserockz changed the title Prep-work for datetime entities Move ESPTime into core esphome namespace Jun 8, 2023
Copy link
Member

@kbx81 kbx81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's about time

@kbx81 kbx81 merged commit 302dea4 into dev Jun 8, 2023
@kbx81 kbx81 deleted the jesserockz-2023-226 branch June 8, 2023 22:24
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants