Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web_server: Return early if no clients connected #6467

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

jesserockz
Copy link
Member

What does this implement/fix?

Even when no clients are connected to the /events endpoint, the JSON is still being generated. This adds an early return to not do anything if there are no clients.

The size_t count() function exists already in the Arduino library, and this PR adds it to the esp-idf implementation.

[19:14:20][V][json:038]: Attempting to allocate 512 bytes for JSON serialization
[19:14:20][V][json:058]: Size after shrink 64 bytes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

probot-esphome bot commented Apr 3, 2024

Hey there @dentra, mind taking a look at this pull request as it has been labeled with an integration (web_server_idf) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@kbx81 kbx81 merged commit 5cc3d60 into dev Apr 3, 2024
59 checks passed
@kbx81 kbx81 deleted the jesserockz-2024-078 branch April 3, 2024 22:14
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants