Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helpers] Move Base64 string to cpp #6819

Merged
merged 2 commits into from
May 27, 2024
Merged

Conversation

gabest11
Copy link
Contributor

What does this implement/fix?

Fix wasting and running out of memory. Also reduces fw size.

Issue #5857

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@gabest11 gabest11 requested a review from a team as a code owner May 27, 2024 19:04
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.13%. Comparing base (4d8b5ed) to head (7d9f707).
Report is 672 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6819      +/-   ##
==========================================
+ Coverage   53.70%   54.13%   +0.42%     
==========================================
  Files          50       50              
  Lines        9408     9619     +211     
  Branches     1654     1698      +44     
==========================================
+ Hits         5053     5207     +154     
- Misses       4056     4086      +30     
- Partials      299      326      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gabest11
Copy link
Contributor Author

Smart alec algo replaced BASE64_CHARS in the title with Base64 chars.

@jesserockz jesserockz added this to the 2024.5.4 milestone May 27, 2024
@jesserockz jesserockz merged commit 6e4fd42 into esphome:dev May 27, 2024
57 checks passed
@jesserockz jesserockz changed the title Base64 chars fix [helpers] Move Base64 string to cpp May 27, 2024
jesserockz pushed a commit that referenced this pull request May 27, 2024
@jesserockz jesserockz mentioned this pull request May 27, 2024
@gabest11 gabest11 deleted the BASE64_CHARS-fix branch May 27, 2024 21:54
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants