-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[safe_mode] Allow user-defined interval for successful boot #6882
Conversation
Adding attempt time to the call
Adding definition of attempt time
Hey there @jsuanet, @kbx81, @paulmonigatti, mind taking a look at this pull request as it has been labeled with an integration ( |
In the doc update, you refer to Also, all CI/tests must be passing before we will review the PR. Thanks for working on this! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6882 +/- ##
==========================================
+ Coverage 53.70% 53.91% +0.20%
==========================================
Files 50 50
Lines 9408 9625 +217
Branches 1654 1698 +44
==========================================
+ Hits 5053 5189 +136
- Misses 4056 4112 +56
- Partials 299 324 +25 ☔ View full report in Codecov by Sentry. |
Hey there @jsuanet, @paulmonigatti, mind taking a look at this pull request as it has been labeled with an integration ( |
I appreciate you taking care of it for me. Just for growth, I committed the init.py twice and it still fell through, was that my fault? |
@NMartin354 Aha, I just took a look at your fork, and you pushed it to a new branch which made it not part of this pull request. The real fault lies in creating the original work and pull request on your fork |
What does this implement/fix?
Adjusts the reboot timeout to a single function instead of serving two functions
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3930
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: