Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-quality] Tidy up some duplicate CONFIG_SCHEMA assignments #7106

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

jesserockz
Copy link
Member

@jesserockz jesserockz commented Jul 18, 2024

What does this implement/fix?

This is just a minor tidy up on some removed components code that was flagged by ruff

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @angelnu, mind taking a look at this pull request as it has been labeled with an integration (ade7953) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
Copy link

Hey there @latonita, mind taking a look at this pull request as it has been labeled with an integration (bmp3xx) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
Copy link

Hey there @latonita, mind taking a look at this pull request as it has been labeled with an integration (ens160) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@kbx81 kbx81 enabled auto-merge (squash) July 18, 2024 23:30
@jesserockz jesserockz disabled auto-merge July 19, 2024 00:12
@jesserockz jesserockz closed this Jul 19, 2024
@jesserockz jesserockz reopened this Jul 19, 2024
@kbx81 kbx81 enabled auto-merge (squash) July 19, 2024 08:27
@jesserockz jesserockz closed this Jul 21, 2024
auto-merge was automatically disabled July 21, 2024 19:44

Pull request was closed

@jesserockz jesserockz reopened this Jul 21, 2024
@jesserockz jesserockz enabled auto-merge (squash) July 21, 2024 19:44
@jesserockz jesserockz merged commit cfb20ab into dev Jul 21, 2024
32 checks passed
@jesserockz jesserockz deleted the jesserockz-2024-287 branch July 21, 2024 20:09
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants