-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add usb_device #7520
base: dev
Are you sure you want to change the base?
add usb_device #7520
Conversation
Hey there @tomaszduda23, CODEOWNERS = ["@tomaszduda23"] And run (message by NeedsCodeownersLabel) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #7520 +/- ##
==========================================
+ Coverage 53.70% 54.02% +0.31%
==========================================
Files 50 50
Lines 9408 9697 +289
Branches 1654 1711 +57
==========================================
+ Hits 5053 5239 +186
- Misses 4056 4127 +71
- Partials 299 331 +32 ☔ View full report in Codecov by Sentry. |
e962f5b
to
0319ac2
Compare
#if defined(USE_ESP32_VARIANT_ESP32S2) || defined(USE_ESP32_VARIANT_ESP32S3) | ||
#include "usb_device.h" | ||
#include "esphome/core/log.h" | ||
#include "USB.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an Arduino Library, new esp32 components should be directly using esp-idf headers and functions, not Arduino ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. There are 2 cases:
- Arduino uses tinyusb for cdc logger
- esp-idf use in rom cdc
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
What does this implement/fix?
show status of usb device. Part of #3917. It is also applicable for cdc logger.
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed:
esphome/esphome-docs#4295