Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bang-bang] Remove assert() #7533

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

kbx81
Copy link
Member

@kbx81 kbx81 commented Oct 3, 2024

What does this implement/fix?

Removes an assert() from bang-bang -- this doesn't need to crash the device here. Changed to print a warning and move along.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

probot-esphome bot commented Oct 3, 2024

Hey there @OttoWinter, mind taking a look at this pull request as it has been labeled with an integration (bang_bang) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@kbx81 kbx81 marked this pull request as draft October 3, 2024 02:25
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.01%. Comparing base (4d8b5ed) to head (d8ad431).
Report is 1393 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #7533      +/-   ##
==========================================
+ Coverage   53.70%   54.01%   +0.30%     
==========================================
  Files          50       50              
  Lines        9408     9695     +287     
  Branches     1654     1711      +57     
==========================================
+ Hits         5053     5237     +184     
- Misses       4056     4127      +71     
- Partials      299      331      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@probot-esphome probot-esphome bot added the core label Oct 3, 2024
@kbx81 kbx81 force-pushed the 20241002-remove-assert-bangbang branch from 3c3384e to fa47f33 Compare October 3, 2024 09:56
@kbx81 kbx81 force-pushed the 20241002-remove-assert-bangbang branch from fa47f33 to d8ad431 Compare October 4, 2024 08:30
@probot-esphome probot-esphome bot removed the core label Oct 4, 2024
@kbx81 kbx81 marked this pull request as ready for review October 4, 2024 08:56
@kbx81 kbx81 changed the title Remove assert() from bang-bang [bang-bang] Remove assert() Oct 5, 2024
@jesserockz jesserockz merged commit 949e61d into esphome:dev Oct 6, 2024
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants