Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change addon startup to services #115

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Change addon startup to services #115

merged 1 commit into from
Dec 6, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 27, 2023 •
edited
Loading

@bdraco bdraco marked this pull request as ready for review November 27, 2023 01:01
@bdraco
Copy link
Member Author

bdraco commented Nov 27, 2023

I don't have a good way to test this though.

@jesserockz
Copy link
Member

Might as well generate for stable and beta too I guess?

@bdraco
Copy link
Member Author

bdraco commented Nov 28, 2023

It looks like they will get generated from the template upon release so probably don't have to update anything but dev AFAICT from 23eca65 and

home-assistant-addon/template/addon_config.yaml

Line 4 in 5729540

# to update the dev addon config (beta/stable configs will be updated on next release by release script)
?

@jesserockz jesserockz merged commit 4ca0b98 into esphome:main Dec 6, 2023
3 checks passed
@codyc1515
Copy link

Could you please post a beta release? I can then confirm if fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesserockz jesserockz jesserockz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Esphome Error: Dashboard unvailable Cannot connect to ESPHome dashboard
3 participants
@bdraco @jesserockz @codyc1515