Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for IWSLT 2024 shared task Indic track #5744

Merged
merged 24 commits into from
May 8, 2024

Conversation

cromz22
Copy link
Contributor

@cromz22 cromz22 commented Apr 17, 2024

What?

Add recipe for IWSLT 2024 shared task Indic track

Why?

There was no recipe

See also

@sw005320 sw005320 added ST Speech translation Recipe labels Apr 17, 2024
@sw005320 sw005320 added this to the v.202405 milestone Apr 17, 2024
@sw005320 sw005320 requested a review from ftshijt April 17, 2024 21:11
Copy link
Collaborator

@ftshijt ftshijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. It would be more than welcome if you can also upload your model to huggingface. But the current recipe looks great to go.

@cromz22
Copy link
Contributor Author

cromz22 commented Apr 19, 2024

Thanks! I've uploaded the models to huggingface and added the links to RESULTS.md.

@cromz22
Copy link
Contributor Author

cromz22 commented Apr 19, 2024

I've opened another pr #5748 to fix issues encountered while adding this recipe. Kindly have a check

@sw005320
Copy link
Contributor

@cromz22, please fix this https://github.com/espnet/espnet/actions/runs/8758179023/job/24038414964?pr=5744#step:8:183

@sw005320 sw005320 closed this Apr 24, 2024
@sw005320 sw005320 reopened this Apr 24, 2024
@sw005320
Copy link
Contributor

sw005320 commented May 7, 2024

@mergify mergify bot added the CI Travis, Circle CI, etc label May 8, 2024
@cromz22
Copy link
Contributor Author

cromz22 commented May 8, 2024

It seems that it was related to GitHub actions' setup-python issue: actions/setup-python#825
To support older versions of Mac, current fix should be fine. If we also want to support latest Mac that uses arm64, I think we need to add another CI test.

@sw005320
Copy link
Contributor

sw005320 commented May 8, 2024

Thanks.
We'll fix the mac related CI error later, which is not related to your PR.
But I want you to fix the shell related error in https://github.com/espnet/espnet/actions/runs/8995442862/job/24710409478?pr=5744#step:8:454

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.51%. Comparing base (89dcf8b) to head (5180c85).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5744       +/-   ##
===========================================
- Coverage   54.34%   32.51%   -21.84%     
===========================================
  Files         767      768        +1     
  Lines       70337    70372       +35     
===========================================
- Hits        38222    22878    -15344     
- Misses      32115    47494    +15379     
Flag Coverage Δ
test_integration_espnet2 48.81% <ø> (?)
test_python_espnet2 ?
test_python_espnetez 14.21% <ø> (?)
test_utils ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cromz22
Copy link
Contributor Author

cromz22 commented May 8, 2024

Sorry for the misunderstanding.
It's resolved now.

@sw005320 sw005320 merged commit 435803c into espnet:master May 8, 2024
33 of 35 checks passed
@sw005320
Copy link
Contributor

sw005320 commented May 8, 2024

Thanks a lot, @cromz22!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Travis, Circle CI, etc ESPnet2 README Recipe ST Speech translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants