Fix building with Rust 1.34 and add a GitHub workflow for checking this property #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uli Schlachter <psychon@znc.in>
Cursor only implements Read if its inner type implements AsRef<[u8]>.
in Rust 1.34, this is not the case for arrays with 128 entries, which
FILE_CONTENTS is. Thus, we have to explicitly turn this into a slice
Compiler error:
error[E0277]: the trait bound `[u8; 128]: std::convert::AsRef<[u8]>` is not satisfied
--> src/parser.rs:225:20
|
225 | assert_eq!(parse_header(&mut cursor).unwrap(), (16, 1));
| ^^^^^^^^^^^^ the trait `std::convert::AsRef<[u8]>` is not implemented for `[u8; 128]`
|
= help: the following implementations were found:
<[T; 0] as std::convert::AsRef<[T]>>
<[T; 10] as std::convert::AsRef<[T]>>
<[T; 11] as std::convert::AsRef<[T]>>
<[T; 12] as std::convert::AsRef<[T]>>
and 30 others
= note: required because of the requirements on the impl of `std::convert::AsRef<[u8]>` for `&[u8; 128]`
= note: required because of the requirements on the impl of `std::io::Read` for `std::io::Cursor<&[u8; 128]>`
note: required by `parser::parse_header`
--> src/parser.rs:58:1
|
58 | fn parse_header(i: &mut impl Read) -> IoResult<(u32, u32)> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Signed-off-by: Uli Schlachter <psychon@znc.in>
|
Maybe we should not lock the msrv on 1.34? I noticed that the parsing code could avoid a couple of allocations by using const generics, but that would require 1.51 (which is still more than 3 years old!) Edit: nevermind all tags are 4 bytes :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thanks for your input in #20. Turns out I already broke the MSRV that you figured out. Here's a fix for that and a workflow to keep this working.
Edit: I want to highlight that only tests do not compile with 1.34. The library itself is fine.