Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(net): Allow to compile without IPv6 enabled #10582

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

me-no-dev
Copy link
Member

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Warnings
⚠️ The Pull Request description looks very brief, please check if more details can be added.
⚠️
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello me-no-dev, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 786d831

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Test Results

 62 files   62 suites   7m 23s ⏱️
 22 tests  21 ✅ 0 💤 1 ❌
144 runs  143 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 786d831.

♻️ This comment has been updated with latest results.

@Jason2866
Copy link
Collaborator

@me-no-dev Great! Thx. Will test ASAP

@Jason2866
Copy link
Collaborator

Tested and build a framework without IPv6 support which worked to build an Arduino sketch with IPv4 only.

@me-no-dev me-no-dev added the Status: Review needed Issue or PR is awaiting review label Nov 7, 2024
@Jason2866
Copy link
Collaborator

When IPv6 is disabled in IDF there is something broken. The example sketch https://github.com/espressif/arduino-esp32/blob/master/libraries/WebServer/examples/HelloServer/HelloServer.ino
does compile connects to the AP but the WebServer is not reachable. Ping gets replys from the esp IP address.

@VojtechBartoska VojtechBartoska added the Status: In Progress Issue is in progress label Nov 11, 2024
@VojtechBartoska VojtechBartoska added this to the 3.1.0 milestone Nov 11, 2024
@VojtechBartoska VojtechBartoska removed the Status: In Progress Issue is in progress label Nov 11, 2024
@Jason2866
Copy link
Collaborator

@me-no-dev Webserver is now reachable with last commit. Build a small Tasmota Variant without IPv6 support. Looks like it is fully working.

Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Good. Tested WiFi Server, Client and Scan.
No IPv6 saves about 28KB flash space.

@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Nov 12, 2024
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested WebServer + Client, both working.

@me-no-dev me-no-dev merged commit f8d9ffb into release/v3.1.x Nov 12, 2024
52 of 57 checks passed
@me-no-dev me-no-dev deleted the feature/no_ipv6 branch November 12, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants