Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added lilygo t-display (esp32-based) board definition #8533

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

PBrunot
Copy link
Contributor

@PBrunot PBrunot commented Aug 15, 2023

Description of Change

This change adds a new board lilygo-t-display based on esp32. Board variants have 4 MB or 16 MB flash memory. All boards come with a TFT display. This board is the predecessor to the already included lilygo-t-display-s3.

Manufacturer Board webpage

Pinmap

Tests scenarios

I have tested my pull request with a Lilygo TDisplay HW rev 1.1 by configuring PlatformIO to use the platform in https://github.com/PBrunot/arduino-esp32#feature-lilygo-tdisplay as framework for arduino-esp32, and uploading a sketch to a destination board successfully. Testing sketch is using serial, TFT display over SPI.

platformio.used for testing

[env:T-Display]
platform = https://github.com/platformio/platform-espressif32.git
board = lilygo_t-display
framework = arduino
monitor_speed = 115200
build_flags = -D ARDUINO_LILYGO_T_DISPLAY_S3
platform_packages =
    framework-arduinoespressif32 @ https://github.com/PBrunot/arduino-esp32#feature-lilygo-tdisplay
lib_deps = 
	moononournation/GFX Library for Arduino@^1.3.7
	Wire
	SPI

Related links

This is required to add support in platformio for the same board, as per platformio esp32 policies : platformio/platform-espressif32#209

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2023

CLA assistant check
All committers have signed the CLA.

this board is the predecessor to the already included lilygo-t-display-s3

added USB defines for t-display
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PBrunot Please take a look on my comments. After its fixed the board addition can be merged :)

boards.txt Outdated Show resolved Hide resolved
boards.txt Show resolved Hide resolved
@P-R-O-C-H-Y P-R-O-C-H-Y added the Resolution: Awaiting response Waiting for response of author label Aug 23, 2023
@PBrunot
Copy link
Contributor Author

PBrunot commented Aug 26, 2023

Thanks, I've implemented your comments.

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Resolution: Awaiting response Waiting for response of author labels Aug 28, 2023
@PBrunot PBrunot force-pushed the feature-lilygo-tdisplay branch from 34527fc to e08332e Compare August 28, 2023 16:19
@me-no-dev me-no-dev merged commit 13772ad into espressif:master Aug 29, 2023
@PBrunot PBrunot deleted the feature-lilygo-tdisplay branch August 29, 2023 12:16
@SuGlider
Copy link
Collaborator

SuGlider commented Sep 1, 2023

Attention::: WRONG FILE NAME ---> pins_arduino.h.txt

I'll fix it in the GPIO48 PR.

@PBrunot
Copy link
Contributor Author

PBrunot commented Sep 1, 2023

Sorry about that & thank you for your fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
Development

Successfully merging this pull request may close these issues.

6 participants