-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added lilygo t-display (esp32-based) board definition #8533
Conversation
this board is the predecessor to the already included lilygo-t-display-s3 added USB defines for t-display
b1792f2
to
13b2586
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PBrunot Please take a look on my comments. After its fixed the board addition can be merged :)
Thanks, I've implemented your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
34527fc
to
e08332e
Compare
Attention::: WRONG FILE NAME ---> pins_arduino.h.txt I'll fix it in the GPIO48 PR. |
Sorry about that & thank you for your fix. |
Description of Change
This change adds a new board lilygo-t-display based on esp32. Board variants have 4 MB or 16 MB flash memory. All boards come with a TFT display. This board is the predecessor to the already included lilygo-t-display-s3.
Manufacturer Board webpage
Pinmap
Tests scenarios
I have tested my pull request with a Lilygo TDisplay HW rev 1.1 by configuring PlatformIO to use the platform in https://github.com/PBrunot/arduino-esp32#feature-lilygo-tdisplay as framework for arduino-esp32, and uploading a sketch to a destination board successfully. Testing sketch is using serial, TFT display over SPI.
platformio.used for testing
Related links
This is required to add support in platformio for the same board, as per platformio esp32 policies : platformio/platform-espressif32#209