don't reset LEDC channel if it wasn't used by camera #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
force-pushed
the
deinit-check
branch
from
f0925cc
to
846554e
Compare
|
Thanks @dhalbert for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
camera_disable_out_clockis called (asCAMERA_DISABLE_OUT_CLOCK()) inesp_camera_deinit()camera_disable_out_clock()stops the clock for LEDC channelg_ledc_channel. But if the camera was never enabled, it will stop channel0, which might be in use by other unrelated things.This fix detects when there is no clock to stop.
See adafruit#1 for background.