feat: add SC031GS camera sensor support #452
Conversation
driver/include/sensor.h
Outdated
| @@ -82,6 +85,7 @@ typedef enum { | |||
| FRAMESIZE_96X96, // 96x96 | |||
| FRAMESIZE_QQVGA, // 160x120 | |||
| FRAMESIZE_QCIF, // 176x144 | |||
| FRAMESIZE_200X200, // 200x200 | |||
There was a problem hiding this comment.
can we have this new frame size in a separate PR? Why is it needed?
There was a problem hiding this comment.
A separate request has been made, PTAL, Thanks.
Only some projects must use this resolution, or do we have other methods to add a custom resolution? Some projects tend to use a custom resolution.
There was a problem hiding this comment.
There are some "hacky" ways, but maybe we need to think of adding an option to do it. Adding to the list as-is could/will break some projects that expect that list to be static. Another option would be to have a call to get a list of available resolutions.
There was a problem hiding this comment.
Maybe there will be some custom resolution requirements later, so if possible, please add a method to support this custom resolution.
WangYuxin-esp
force-pushed
the
feature/add_sc031gs_camera_sensor_driver
branch
from
1406696
to
6630165
Compare
driver/include/sensor.h
Outdated
| @@ -82,8 +85,8 @@ typedef enum { | |||
| FRAMESIZE_96X96, // 96x96 | |||
| FRAMESIZE_QQVGA, // 160x120 | |||
| FRAMESIZE_QCIF, // 176x144 | |||
| FRAMESIZE_200X200, // 200x200 | |||
There was a problem hiding this comment.
seems you have one more place left here and somehow removed 240x240? Could you please fix this?
There was a problem hiding this comment.
This error has been fixed.
WangYuxin-esp
force-pushed
the
feature/add_sc031gs_camera_sensor_driver
branch
from
6630165
to
9d9e7d6
Compare
No description provided.