-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance changes in the component, examples and readme #597
Conversation
d45965e
to
5085977
Compare
5085977
to
3ca99c9
Compare
3ca99c9
to
2ddedb9
Compare
@@ -11,11 +11,8 @@ jobs: | |||
runs-on: ubuntu-latest | |||
strategy: | |||
matrix: | |||
idf_ver: ["release-v4.1", "release-v4.2", "release-v4.3"] | |||
idf_ver: ["release-v4.3"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to add some newer versions? 4.4, 5.0 and 5.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are already there in build-examples-pedantic
job below, around line 29.
As I understand, when we have enabled more strict warnings checks in CI, we only did so for v4.4 and later, and split the jobs into
- a job for the old releases without warnings checks
- a job for the new releases with warnings checks
I guess the two jobs could be folded into one. But it's probably not so important since release/v4.3 will be EOL in a month (December 15) and we can remove this job completely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah... that explains my confusion.
@@ -11,11 +11,8 @@ jobs: | |||
runs-on: ubuntu-latest | |||
strategy: | |||
matrix: | |||
idf_ver: ["release-v4.1", "release-v4.2", "release-v4.3"] | |||
idf_ver: ["release-v4.3"] | |||
idf_target: ["esp32", "esp32s2"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could also add S3 to the list of targets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already there around line 35.
@me-no-dev Thanks for reviewing! Could you please tag 2.0.6 or 2.1.0 to get the new version with the example updates deployed? Otherwise the `idf.py create-project-from-example" command mentioned in the readme won't work. |
@igrr yes. Just asked @WangYuxin-esp to check a small PR about the GC sensors and will tag a new release. |
This PR combines several minor changes, mostly related to updating the repository structure to match the currently recommended one for managed components:
examples/camera_example
. At this location, it will be found automatically by the Component Manager, and the example will be made available for download fromidf.py create-project-from-example
and from within the IDEs.register_component
calls withidf_component_register
. The last version which didn't supportidf_component_register
was v3.3, which is EOL for a long time.override_path
)esp32-camera
component did not declare an interface dependency ondriver
. This issue lead to a compilation error (driver/gpio.h not found) ifmain
component didn't have its own dependency ondriver
.