Support for 64MB+ mbit flashes (ESPTOOL-500) #769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
|
Hello @johnboiles, thanks for contributing! I will verify this and put this PR through our internal review queue! |
|
🎉 |
|
@johnboiles thanks again for bringing this up! |
|
Thanks for getting this in quickly! |
4 tasks
espressif-bot
pushed a commit
that referenced
this pull request
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for 64MB (512mbit) and above flashes which (strangely) eschew the convention that goes from 0x12 - 0x19 for 256KB - 32MB flashes and jumps to 0x20 - 0x22 for 64MB - 256MB flashes. This pattern has been confirmed for Micron, Winbond, and Gigadevice flashes.
See related IDF PRs for further discussion: espressif/esp-idf#9381 espressif/esp-idf#9566
I have tested this change with
W25Q512JVEQchips (64MB) on ESP32-S3.