Closes estree/estree#6 #99
Conversation
This picks up @dherman [earlier commit](dherman@70ba4ab) where it left off. Also attempted to addres @michaelficarra's concern about raw string source's being wrapped with quotes.
| } | ||
| ``` | ||
|
|
||
| The body of a function, which is a block statement that may contain a directive prologue. |
There was a problem hiding this comment.
A Directive Prologue is always present (but sometimes empty). Perhaps "… a block statement that may begin with directives"?
There was a problem hiding this comment.
Alternatively, we could put separate array directives in front of body.
There was a problem hiding this comment.
Alternatively, we could put separate array
directivesin front ofbody.
That would either remove directives from body (which breaks backwards compatibility) or reference them twice (which is not JSON-friendly).
There was a problem hiding this comment.
Please see my comment about interface Directive below - it already breaks backward compatibility!
There was a problem hiding this comment.
How does inheriting from ExpressionStatement to add a property without changing anything else (including type) break backwards compatibility?
|
|
||
| A directive from the directive prologue of a script or function. | ||
| The `directive` property is the raw string source of the directive. | ||
| This value includes single or double wrapping quotes. |
There was a problem hiding this comment.
I don't think quotes should be included in the value. "use strict" and 'use strict' should yield identical ASTs.
There was a problem hiding this comment.
Agreed. They're insignificant.
This picks up @dherman's earlier commit where it left off.
Also attempted to addres @michaelficarra's concern about raw string source's being wrapped with quotes.