Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-hubspot-native: fix variable access bug #2122

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

williamhbaker
Copy link
Member

@williamhbaker williamhbaker commented Nov 4, 2024

Description:

Quick fix of a bug introduced by the ordering of the the logging statement in fetch_search_objects_modified_at, where result.total is not available initializing the variable in the first loop.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

Quick fix of a bug introduced by the ordering of the the logging statement in
`fetch_search_objects_modified_at`, where `result.total` is not available
initializing the variable in the first loop.
Copy link
Contributor

@Alex-Bair Alex-Bair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamhbaker williamhbaker merged commit f71dc3c into main Nov 4, 2024
73 of 77 checks passed
@williamhbaker williamhbaker deleted the wb/hsn-fix branch November 4, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants