exports update and fxmanifest vers #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added GetAccount export along with the existing two exports
Removed duplicate export for shared account (already declared in fxmanifest.lua). Moved AddAccount into fxmanifest.lua as well
Updated fxmanifest script version (hasn't been updated in ages!)
|
In my opinion exports should always be put in the file itself (here: server.lua). |
|
@t1ger-scripts Hi! Yes as @Mirrrrrow says don't use this old system it is much more visible, searchable, debuggable if you put it directly in the file than in fxmanifest. Please modify this so that everything is exported in that file. Then I can merge it. |
Gellipapa
requested changes
Jul 31, 2024
Gellipapa
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export for shared account already existed in fxmanifest.lua, so removed from server/main.lua.
Alongside the other exports, I added GetAccount and removed it from the server file as well.
Also figured to update the script version, as it hasn't been done in ages.