refactor: Localize functions + Remove separate threads #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In theory, this should micro-optimize the server load.
In theory should provide optimization to the client.
|
Refactored the client too. |
Gellipapa
reviewed
Oct 5, 2024
| end | ||
|
|
||
| function getVehicleFromModel(model) | ||
| local function getVehicleFromModel(model) |
There was a problem hiding this comment.
Hi! I'm not sure if this works if you're using local here because this method has been used before. Did you test the code did it work?
There was a problem hiding this comment.
Hey there! I did not test however I am happy to test today after work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theory, this should micro-optimize the server load. (Char count behaviour slightly rewritten too and removed the need for a function when it is unused in other places.