Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominate @fuweid as a bbolt reviewer #648

Closed
ahrtr opened this issue Dec 21, 2023 · 9 comments
Closed

Nominate @fuweid as a bbolt reviewer #648

ahrtr opened this issue Dec 21, 2023 · 9 comments

Comments

@ahrtr
Copy link
Member

ahrtr commented Dec 21, 2023

Hi all, I'd like to nominate @fuweid as a reviewer of bbolt, reasons,

  • he has deep understanding on bbolt;
  • great contribution to bbolt, especially the recent robustness test for bbolt, and continuous hard work on the investigation on data corruption issue together with me;
  • continuous & active reviewing PRs in bbolt (and also etcd).

Sponsored by

cc @jmhbnz @mitake @ptabor @serathius @spzala @wenjiaswe

@ahrtr
Copy link
Member Author

ahrtr commented Dec 21, 2023

Also @fuweid is actually already a reviewer of etcd, and a de-fact reviewer of bbolt.

@ptabor
Copy link
Contributor

ptabor commented Dec 21, 2023

Great. +1 from me.

@serathius
Copy link
Member

+1, thanks @fuweid for all your work.

@fuweid
Copy link
Member

fuweid commented Dec 21, 2023

Thanks @ahrtr @ptabor @serathius for that support!

@ahrtr
Copy link
Member Author

ahrtr commented Dec 21, 2023

Thanks @ahrtr @ptabor @serathius for that support!

@fuweid Please raise a PR to add you as a reviewer into the OWNERs file.

@spzala
Copy link
Member

spzala commented Dec 21, 2023

+1 Thank you @fuweid @ahrtr

@wenjiaswe
Copy link

+1, great job @fuweid and really appreciate your contribution in etcd! And this is a great successful story of mentorship program, @ahrtr thank you for your mentorship and leadership here!

@ahrtr
Copy link
Member Author

ahrtr commented Dec 21, 2023

Resolved in #649

@ahrtr ahrtr closed this as completed Dec 21, 2023
@fuweid
Copy link
Member

fuweid commented Dec 22, 2023

Thanks @wenjiaswe @spzala !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants