tests/*: introduce go-dmflakey #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuweid
force-pushed
the
init-godmflakey
branch
from
5b054e6
to
7b6b646
Compare
|
ping @ahrtr @serathius @jmhbnz REF: #622 (comment) |
ahrtr
reviewed
Dec 5, 2023
ahrtr
reviewed
Dec 5, 2023
fuweid
force-pushed
the
init-godmflakey
branch
from
7b6b646
to
5c9f8ac
Compare
ahrtr
reviewed
Dec 6, 2023
tests/dmflakey/dmflakey.go
Outdated
Comment on lines
26
to
27
| defaultImgSize int64 = 1024 * 1024 * 1024 * 10 // 10 GiB | ||
| defaultInterval = 2 * time.Minute |
There was a problem hiding this comment.
Please define the two items as constants.
| // SyncFS attempts to synchronize filesystem before inject failure. | ||
| syncFS bool | ||
| // interval is used to determine how long the failure lasts. | ||
| interval time.Duration |
There was a problem hiding this comment.
To double check, in positive case (e.g. AllowWrites), the interval is the "up interval"; otherwise it's the "down interval"? If yes, please add a comment to make it clearer.
This commit is to add go-binding for go-dmflakey. It's used to simulate powerfailure with common filesystems. Signed-off-by: Wei Fu <fuweid89@gmail.com>
fuweid
force-pushed
the
init-godmflakey
branch
from
5c9f8ac
to
b05bec2
Compare
ahrtr
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is to add go-binding for go-dmflakey. It's used to simulate powerfailure with common filesystems.