bucket,cursor: clarify sort order and seek algorithm #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptabor
reviewed
Oct 22, 2020
cursor.go
Outdated
| @@ -110,7 +111,7 @@ func (c *Cursor) Prev() (key []byte, value []byte) { | |||
| return k, v | |||
| } | |||
|
|
|||
| // Seek moves the cursor to a given key and returns it. | |||
| // Seek moves the cursor to a given key using a binary search and returns it. | |||
There was a problem hiding this comment.
nit: I would call it "b-tree search" (binary search is only within a single page)
ptabor
approved these changes
Oct 22, 2020
The sort order isn't mentioned anywhere except one sentence in the readme. So is seek. Although it can be inferred from B+tree and other hints, it is important to be able to confirm from just reading doc comments. So, make it explicit.
ptabor
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sort order isn't mentioned anywhere except one sentence in the readme. So is seek. Although it can be inferred from B+tree and other hints, it is important to be able to confirm from just reading doc comments. So, make it explicit.