compact: open src file readonly #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptabor
approved these changes
Oct 18, 2021
|
Thank you. Looks good to me. |
|
Is there still something preventing this being merged? |
|
@missinglink No. Merged. |
|
@missinglink, you are the man/etc.~'pc' |
|
ReadOnly is broken on Windows without #307 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
compactCLI command opens the source file as0444but doesn't currently setReadOnly: true.it therefore requests a
read-writefile lock on the source database when it only really needsread-only.this is due to the flock code only considering the
db.readOnlybool and not theos.FileMode.the problem is that if one or more processes have
read-onlylocks then this operation will stall waiting to acquire a write lock that it doesn't need 🤷♂️with this PR the
ReadOnly: trueoption is set explicitly, meaning that it will play nice with other processes which are also read-only.