-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factor out (bolt)testing library. #360
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptabor
force-pushed
the
20221220-btesting
branch
4 times, most recently
from
December 20, 2022 16:46
69c4fc0
to
c703f86
Compare
ptabor
force-pushed
the
20221220-btesting
branch
4 times, most recently
from
December 21, 2022 20:32
d97ef7d
to
615a11c
Compare
ahrtr
reviewed
Dec 28, 2022
ptabor
force-pushed
the
20221220-btesting
branch
from
December 28, 2022 07:47
0d4d145
to
7d48f48
Compare
ahrtr
reviewed
Dec 28, 2022
ahrtr
reviewed
Dec 28, 2022
ptabor
force-pushed
the
20221220-btesting
branch
2 times, most recently
from
December 28, 2022 07:59
966ae41
to
836fdbd
Compare
Please also resolve the conflict. |
ptabor
force-pushed
the
20221220-btesting
branch
from
December 28, 2022 08:01
836fdbd
to
43ca583
Compare
ahrtr
reviewed
Dec 28, 2022
ahrtr
approved these changes
Dec 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me with a couple of minor comments.
fuweid
reviewed
Dec 28, 2022
ptabor
force-pushed
the
20221220-btesting
branch
4 times, most recently
from
December 28, 2022 14:16
568efe0
to
de1c666
Compare
Thanks to putting it outside the bbolt_test package it can be used to test other packages. The replacement of the bbolt_test variant inlined in db_test.go is to be performed in a follow up PR. Signed-off-by: Piotr Tabor <ptab@google.com>
Signed-off-by: Piotr Tabor <ptab@google.com>
Signed-off-by: Piotr Tabor <ptab@google.com>
Signed-off-by: Piotr Tabor <ptab@google.com>
Signed-off-by: Piotr Tabor <ptab@google.com>
Signed-off-by: Piotr Tabor <ptab@google.com>
ptabor
force-pushed
the
20221220-btesting
branch
from
December 28, 2022 14:18
de1c666
to
1f46d6c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor out (bolt)testing library.
Thanks to putting it outside the bbolt_test package it can be used to test other packages.
The replacement of the bbolt_test variant inlined in db_test.go is to be performed in a follow up PR.
This is part of: #225