Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out (bolt)testing library. #360

Merged
merged 6 commits into from
Dec 28, 2022
Merged

Conversation

ptabor
Copy link
Contributor

@ptabor ptabor commented Dec 20, 2022

Factor out (bolt)testing library.

Thanks to putting it outside the bbolt_test package it can be used to test other packages.
The replacement of the bbolt_test variant inlined in db_test.go is to be performed in a follow up PR.

This is part of: #225

unix_test.go Outdated Show resolved Hide resolved
@ptabor ptabor force-pushed the 20221220-btesting branch 2 times, most recently from 966ae41 to 836fdbd Compare December 28, 2022 07:59
@ahrtr
Copy link
Member

ahrtr commented Dec 28, 2022

Please also resolve the conflict.

internal/btesting/btesting.go Outdated Show resolved Hide resolved
internal/btesting/btesting.go Outdated Show resolved Hide resolved
internal/btesting/btesting.go Outdated Show resolved Hide resolved
internal/btesting/btesting.go Outdated Show resolved Hide resolved
internal/btesting/btesting.go Outdated Show resolved Hide resolved
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me with a couple of minor comments.

tx_test.go Outdated Show resolved Hide resolved
@ptabor ptabor force-pushed the 20221220-btesting branch 4 times, most recently from 568efe0 to de1c666 Compare December 28, 2022 14:16
Thanks to putting it outside the bbolt_test package it can be used to test other packages.
The replacement of the bbolt_test variant inlined in db_test.go is to be performed in a follow up PR.

Signed-off-by: Piotr Tabor <ptab@google.com>
Signed-off-by: Piotr Tabor <ptab@google.com>
Signed-off-by: Piotr Tabor <ptab@google.com>
Signed-off-by: Piotr Tabor <ptab@google.com>
Signed-off-by: Piotr Tabor <ptab@google.com>
Signed-off-by: Piotr Tabor <ptab@google.com>
@ptabor ptabor merged commit a0def34 into etcd-io:master Dec 28, 2022
@ahrtr ahrtr mentioned this pull request Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants